[GitHub] carbondata pull request #2477: [CARBONDATA-2539][MV] Fix predicate subquery ...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2477#discussion_r204431642
  
    --- Diff: 
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala 
---
    @@ -463,6 +485,23 @@ object MVHelper {
         }
       }
     
    +  // Create the aliases using two plan outputs mappings.
    +  def createAliases(mappings: Seq[(NamedExpression, NamedExpression)]): 
Seq[NamedExpression] = {
    +    val oList = for ((o1, o2) <- mappings) yield {
    --- End diff --
    
    it is better to use `map` instead of `for`


---