GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/2542
[CARBONDATA-2772] Size based dictionary fallback is failing even threâ¦
Issue:- Size Based Fallback happened even threshold is not reached.
RootCause:- Current size calculation is wrong. it is calculated for each
data. instead of generated dictionary data .
Solution :- Current size should be calculated only for generated dictionary
data.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Tests manually in 3 Node setup with 2 billion records.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2772
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2542
----
commit 13219ad527a0e8d0cd6c1f46b4e132696562f5f1
Author: BJangir <babulaljangir111@...>
Date: 2018-07-23T16:44:12Z
[CARBONDATA-2772] Size based dictionary fallback is failing even threshold
is not reached.
----
---
