Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2538#discussion_r204608952
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -665,9 +665,21 @@ public static String getCarbonIndexFileName(String
actualBlockName) {
* @return
*/
public static String getShardName(String actualBlockName) {
- return DataFileUtil.getTaskNo(actualBlockName) + "-" +
DataFileUtil.getBucketNo(actualBlockName)
- + "-" + DataFileUtil.getSegmentNo(actualBlockName) + "-" +
DataFileUtil
- .getTimeStampFromFileName(actualBlockName);
+ String segmentNoStr = DataFileUtil.getSegmentNo(actualBlockName);
+ StringBuilder shardName = new StringBuilder();
+ // data before version 1.4 does not have segmentNo in filename
--- End diff --
Should this be moved to else block?
---
