GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2546
[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data
type is SHORT_INT
problem:
[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data
type is SHORT_INT
solution: If ENABLE_OFFHEAP_SORT = false, in carbon property.
UnsafeFixLengthColumnPage.java will use different compress logic. Not the raw
compression. In that case, for SHORT_INT data type , conversion need to handle.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? NA
- [ ] Any backward compatibility impacted? NA
- [ ] Document update required? NA
- [ ] Testing done
updated UT. Which will run all adaptive test cases with
ENABLE_OFFHEAP_SORT = false.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA. NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajantha-bhat/carbondata issue_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2546
----
commit 1e8d06a219010983dd9b97b6869206b3678ac68f
Author: ajantha-bhat <ajanthabhat@...>
Date: 2018-07-24T07:03:47Z
[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap. if, target
datatype is SHORT_INT
----
---
