Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2540#discussion_r204682071
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
 ---
    @@ -221,7 +223,30 @@ public void setNumberOfPages(int numberOfPages) {
           output.writeInt(measureChunksLength.get(i));
         }
         writeChunkInfoForOlderVersions(output);
    +    serializeMinMaxValues(output);
    +  }
     
    +  /**
    +   * serialize min max values
    +   *
    +   * @param output
    +   * @throws IOException
    +   */
    +  private void serializeMinMaxValues(DataOutput output) throws IOException 
{
    --- End diff --
    
    ok..I will remove serialization of min/max and read footer using 
useMinMaxForPruning flag


---

Reply via email to