Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2574#discussion_r205995542
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -223,17 +222,15 @@ protected short getBlockletId(DataMapRow dataMapRow) {
return dataMapRow.getShort(BLOCKLET_ID_INDEX);
}
- protected ExtendedBlocklet createBlocklet(DataMapRow row, String
fileName, short blockletId,
- boolean useMinMaxForPruning) {
+ protected ExtendedBlocklet createBlocklet(DataMapRow row, String
fileName, short blockletId) {
if (isLegacyStore) {
- return super.createBlocklet(row, fileName, blockletId,
useMinMaxForPruning);
+ return super.createBlocklet(row, fileName, blockletId);
--- End diff --
yes, there are test errors about this problem
---
