GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2580
[CARBONDATA-2799][BloomDataMap] Fix bugs in querying with bloom datamap on
preagg with dictionary column
For preaggregate table, if the groupby column is dictionary column in
parent table, the preaggregate table will inherit the dictionary
encoding as well as the dictionary file from the parent table.
So for dictionary columns, during query with bloom, we need to
convert the plain filter value to dictionarty encoded value based on
parent table's dictionary file.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`Added test`
- How it is tested? Please attach test report.
`Tested in local machine`
- Is it a performance related change? Please attach the performance
test report.
`NO`
- Any additional information to help reviewers in testing this
change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0730_bug_bloom_preagg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2580
----
commit c097efac3732f145f1af2bef9274d571d20ebad0
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-07-30T09:50:51Z
Fix bugs in querying with bloom datamap on preagg with dictionary column
For preaggregate table, if the groupby column is dictionary column in
parent table, the preaggregate table will inherit the dictionary
encoding as well as the dictionary file from the parent table.
So for dictionary columns, during query with bloom, we need to
convert the plain filter value to dictionarty encoded value based on
parent table's dictionary file.
----
---
