Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2577#discussion_r206414429
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/row/IntermediateSortTempRow.java
---
@@ -54,35 +54,43 @@ public IntermediateSortTempRow(int[] dictSortDims,
byte[][] noDictSortDims,
/**
* deserialize from bytes array to get the no sort fields
* @param outDictNoSort stores the dict & no-sort fields
- * @param outNoDictNoSortAndVarcharDims stores the no-dict & no-sort
fields,
- * including complex and varchar fields
+ * @param outNoDictNoSort stores all no-dict & no-sort fields,
+ * including complex and varchar fields
* @param outMeasures stores the measure fields
* @param dataTypes data type for the measure
*/
- public void unpackNoSortFromBytes(int[] outDictNoSort, byte[][]
outNoDictNoSortAndVarcharDims,
- Object[] outMeasures, DataType[] dataTypes, int varcharDimCnt) {
+ public void unpackNoSortFromBytes(int[] outDictNoSort, byte[][]
outNoDictNoSort,
+ Object[] outMeasures, DataType[] dataTypes, int varcharDimCnt, int
complexDimCnt) {
--- End diff --
add the comment doc for complexDimCnt
---
