[GitHub] carbondata pull request #2587: [CARBONDATA-2806] Delete delete delta files u...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2587#discussion_r206420686
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java ---
    @@ -75,21 +76,21 @@ public static void 
physicalFactAndMeasureMetadataDeletion(
             absoluteTableIdentifier,
             currentDetails,
             isForceDelete,
    -        specs);
    +        specs,
    +        currentDetails);
         if (newAddedLoadHistoryList != null && newAddedLoadHistoryList.length 
> 0) {
           physicalFactAndMeasureMetadataDeletion(
               absoluteTableIdentifier,
               newAddedLoadHistoryList,
               isForceDelete,
    -          specs);
    +          specs,
    +          currentDetails);
         }
       }
     
    -  public static void physicalFactAndMeasureMetadataDeletion(
    -      AbsoluteTableIdentifier absoluteTableIdentifier,
    -      LoadMetadataDetails[] loadDetails,
    -      boolean isForceDelete,
    -      List<PartitionSpec> specs) {
    +  private static void physicalFactAndMeasureMetadataDeletion(
    +      AbsoluteTableIdentifier absoluteTableIdentifier, 
LoadMetadataDetails[] loadDetails,
    --- End diff --
    
    ok


---