GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2594
[CARBONDATA-2809][DataMap] Skip rebuilding for non-lazy datamap
# Problems & RootCause:
For non-lazy (deferred rebuild) datamap, the data of datamap will be
generated immediately after:
1. the datamap is created
2. the main table is loaded
So there is no need to rebuild this datamap.
Actually, it will encounter error if we trigger rebuilding for these
datamaps due to the existence of old data.
# Solution:
If the datamap is not lazy, we will skip the rebuild procedure and only
print logs for it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`NO`
- How it is tested? Please attach test report.
`Tested in local`
- Is it a performance related change? Please attach the performance
test report.
`NO`
- Any additional information to help reviewers in testing this
change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0801_skip_rebuild
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2594.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2594
----
commit 052b683a9076462c607c73a183697eaae2bc3848
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-08-01T08:58:54Z
Skip rebuilding for non-lazy datamap
Problems & RootCause:
For non-lazy (deferred rebuild) datamap, the data of datamap will be
generated immediately after:
1. the datamap is created
2. the main table is loaded
So there is no need to rebuild this datamap.
Actually, it will encounter error if we trigger rebuilding for these
datamaps due to the existence of old data.
Solution:
If the datamap is not lazy, we will skip the rebuild procedure and only
print logs for it.
----
---
