Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2607#discussion_r207771253
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java
---
@@ -73,7 +73,7 @@ public static CarbonVectorBatch allocate(StructField[]
schema,
}
private CarbonColumnVectorImpl createDirectStreamReader(int batchSize,
DataType dataType,
- StructField field, Dictionary dictionary, SliceArrayBlock
dictionarySliceArrayBlock) {
+ StructField field, Dictionary dictionary, Block
dictionarySliceArrayBlock) {
--- End diff --
better to modify the names also for readability and maintainability
purpose.
dictionarySliceArrayBlock --> dictionaryBlock
---
