Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2588#discussion_r208198390
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java
---
@@ -111,18 +108,15 @@ public void addFileToMerge(File sortTempFile) {
}
public void startFileMergingIfPossible() {
- File[] fileList = null;
- synchronized (lockObject) {
- if (procFiles.size() >=
parameters.getNumberOfIntermediateFileToBeMerged()) {
+ File[] fileList;
+ if (procFiles.size() >=
parameters.getNumberOfIntermediateFileToBeMerged()) {
--- End diff --
@mohammadshahidkhan Yes you are right but in this case UnsafeSortDataRow
processing will be slower as it will read/ sort and write so chances of above
condition is negligible, because of this double check is not added here
---
