[GitHub] carbondata pull request #2619: [CARBONDATA-2819] Fixed cannot drop preagg da...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2619#discussion_r208819917
  
    --- Diff: 
integration/spark2/src/main/java/org/apache/carbondata/datamap/PreAggregateDataMapProvider.java
 ---
    @@ -77,13 +79,15 @@ private void validateDmProperty(DataMapSchema 
dataMapSchema)
       }
     
       @Override
    -  public void cleanMeta() {
    +  public void cleanMeta() throws IOException {
    +    DataMapSchema dataMapSchema = getDataMapSchema();
         dropTableCommand = new CarbonDropTableCommand(
             true,
             new Some<>(dbName),
             tableName,
             true);
         dropTableCommand.processMetadata(sparkSession);
    +    
DataMapStoreManager.getInstance().dropDataMapSchema(dataMapSchema.getDataMapName());
    --- End diff --
    
    Can you check how MV deal with this? In another word, what's the logic of 
dropping a MV?


---