GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2635
[CARBONDATA-2856] Fix bug in bloom index on multiple dictionary columns
During direct generating bloom index for dictionary and date columns, we
will use MdkKeyGenerator to get the surrogate key. But the
MdkKeyGenerator is for all MDK, so we need to pad fake bytes to mdk.
Finally, the generator will only deal with the real parts of the mdk and
get the final value.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`Test modified to cover this problem`
- How it is tested? Please attach test report.
`Tested in local machine`
- Is it a performance related change? Please attach the performance
test report.
`NO`
- Any additional information to help reviewers in testing this
change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata
0815_bug_bloom_dict_write
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2635.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2635
----
commit 9a7f9e1eb59320b55eaa833ab9c9ff8135a585fe
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-08-15T02:36:48Z
Fix bug in bloom index on multiple dictionary columns
During direct generating bloom index for dictionary and date columns, we
will use MdkKeyGenerator to get the surrogate key. But the
MdkKeyGenerator is for all MDK, so we need to pad fake bytes to mdk.
Finally, the generator will only deal with the real parts of the mdk and
get the final value.
----
---
