Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2627#discussion_r210204028
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
    @@ -237,6 +237,21 @@ object CarbonEnv {
         getCarbonTable(tableIdentifier.database, 
tableIdentifier.table)(sparkSession)
       }
     
    +  /**
    +   * whether the classification identifier is a carbon table
    --- End diff --
    
    The current expression is improper, it seems that this method returns a 
boolean which actually is not.
    So it can be optimized to
    ```
    This method returns corresponding CarbonTable, it will return None if it's 
not a CarbonTable
    ```


---

Reply via email to