GitHub user Sssan520 opened a pull request:
https://github.com/apache/carbondata/pull/2641
[CARBONDATA-2819] Fixed cannot drop preagg datamap on table which has other
type datamaps
As we know, carbon now write preagg datamap info to main table schema and
write other type datamap info like bloom or lucene to .dmschema file in _system
folder. When dropping datamap, we should both check the .dmschema files and
main table info if has the datamap which to be deleted.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [No] Any interfaces changed?
- [No] Any backward compatibility impacted?
- [No] Document update required?
- [Yes] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [Na] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Sssan520/carbondata droppreaggsimple
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2641
----
commit 94edb0d78d816c8fa108e761c3313c588dc794f1
Author: Sssan520 <liangap2008@...>
Date: 2018-07-02T11:12:24Z
[CARBONDATA-2819] Fixed cannot drop preagg datamap on table if the table
has other type datamaps
----
---
