[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

[KanakaKumar]

Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2623#discussion_r211931833
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
 ---
    @@ -435,14 +436,16 @@ class CarbonScanRDD[T: ClassTag](
                   "true")
                 if (carbonRecordReader == null) {
                   new CarbonRecordReader(model,
    -                
format.getReadSupportClass(attemptContext.getConfiguration), inputMetricsStats)
    +                
format.getReadSupportClass(attemptContext.getConfiguration),
    +                inputMetricsStats,
    +                getConf)
                 } else {
                   carbonRecordReader
                 }
               } else {
                 new CarbonRecordReader(model,
                   format.getReadSupportClass(attemptContext.getConfiguration),
    -              inputMetricsStats)
    +              inputMetricsStats, getConf)
    --- End diff --
    
    In the executor side avoid calling getConf  multiple times. Instead we can 
take from FileFactory.


---