GitHub user QiangCai opened a pull request:
https://github.com/apache/carbondata/pull/2657
[CARBONDATA-2884] Rename the methods of ByteUtil class to avoid the misuse
The method toBytes will execute XOR operation on data.
So the result is not the byte array of the real value.
Better to rename the methods of ByteUtil class to avoid the misuse
- [x] Any interfaces changed?
yes,
1. rename the old toBytes methods to toXorBytes
2. new toBytes methods return the real byte array
- [x] Any backward compatibility impacted?
no
- [x] Document update required?
yes, added java doc
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
added test case
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
small changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/carbondata byteutil
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2657.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2657
----
commit e26c3c2d61ea4546754f7e112434dae2d724709f
Author: QiangCai <qiangcai@...>
Date: 2018-08-24T01:56:43Z
rename the methods to avoid the misuse
----
---
