[GitHub] carbondata pull request #2653: [CARBONDATA-2874] Support SDK writer as threa...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2653#discussion_r212533163
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
 ---
    @@ -268,6 +268,49 @@ public synchronized OutputCommitter 
getOutputCommitter(TaskAttemptContext contex
             executorService);
       }
     
    +  public RecordWriter<NullWritable, ObjectArrayWritable> 
getMultiThreadRecordWriter(
    --- End diff --
    
    I feel no need to add separate method, take configuration of number of 
threads of conf object and generate record writer


---