Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2659#discussion_r213202408
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepWithNoConverterImpl.java
 ---
    @@ -287,8 +282,6 @@ private CarbonRowBatch getBatch() {
         private Object[] convertToNoDictionaryToBytes(Object[] data, 
DataField[] dataFields) {
           Object[] newData = new Object[data.length];
           BadRecordLogHolder logHolder = new BadRecordLogHolder();
    --- End diff --
    
    better to create class level bad record holder object, as it is dummy 


---

Reply via email to