GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2665
[CARBONDATA-2897][DataMap] Optimize datamap chooser
In this PR,
1. Remove code for merging into one datamap when some datamap hits both
child nodes of And/Or expression in DataMapChooser. This aims to make datamap
focus on pruning single index column without any logic process. Leave logic
stuff to be done by AndDataMapExprWrapper and OrDataMapExprWrapper
2. Only extract ColumnExpression of Expression which our datamap can handle
in DataMapChooser.
3. Add short circuit to return pruned result when result of left node is
empty in AndDataMapExprWrapper.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata dmChooser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2665
----
commit 2c03e75f7d77df7609f2b054dcf93bdd7256bfa8
Author: Manhua <kevinjmh@...>
Date: 2018-08-28T11:51:52Z
datamap chooser
----
---
