[GitHub] carbondata pull request #2678: [CARBONDATA-2909] Multi user support for SDK ...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2678#discussion_r214617416
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/reader/ThriftReader.java ---
    @@ -87,6 +88,15 @@ public void open() throws IOException {
         binaryIn = new TCompactProtocol(new 
TIOStreamTransport(dataInputStream));
       }
     
    +  /**
    +   * Opens the fileName for reading.
    +   */
    +  public void open(Configuration configuration) throws IOException {
    --- End diff --
    
    Better take from constructor


---