Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2685#discussion_r214627216
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
 ---
    @@ -135,6 +135,18 @@ private static BitSet getPresenceMeta(
        * @throws IOException problem while reading the index file
        */
       public List<DataFileFooter> getIndexInfo(String filePath, byte[] 
fileData) throws IOException {
    +    return getIndexInfo(filePath, fileData, true);
    +  }
    +
    +  /**
    +   * Below method will be used to get the index info from index file
    +   *
    +   * @param filePath           file path of the index file
    --- End diff --
    
    These comments do no provide any useful information, better to remove them


---

Reply via email to