Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2692#discussion_r214890206
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
 ---
    @@ -2359,6 +2359,46 @@ class TestNonTransactionalCarbonTable extends 
QueryTest with BeforeAndAfterAll {
         checkAnswer(sql("select * from sdkOutputTable"), 
Seq(Row(Timestamp.valueOf("1970-01-02 16:00:00"), 
Row(Timestamp.valueOf("1970-01-02 16:00:00")))))
       }
     
    +  test("test Sort Scope with SDK") {
    --- End diff --
    
    This file contains too much code... 2.6k lines of code!
    I think you can refactor it later.


---

Reply via email to