GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2696
[CARBONDATA-2902][DataMap] Fix showing negative pruning result for explain
command
#2676 used method `ByteBuffer.getShort(int index)` to get number of
blocklets in block, but it used wrong parameter. The `index` is index of byte
instead of index of short. So it needs to multiply bytes of short type
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata explain_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2696.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2696
----
commit 1cdfc5c8e592f53170cf942bfbb45cc5e5d67719
Author: Manhua <kevinjmh@...>
Date: 2018-09-06T09:09:21Z
fix negative blocklet skipped when cache level is block
----
---
