Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2692#discussion_r215634003
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -311,15 +326,15 @@ public CarbonWriterBuilder
withTableProperties(Map<String, String> options) {
}
for (Map.Entry<String, String> entry : options.entrySet()) {
- if (entry.getKey().equalsIgnoreCase("equalsIgnoreCase")) {
+ if (entry.getKey().equalsIgnoreCase("blocksize")) {
this.withBlockSize(Integer.parseInt(entry.getValue()));
} else if (entry.getKey().equalsIgnoreCase("blockletsize")) {
this.withBlockletSize(Integer.parseInt(entry.getValue()));
} else if
(entry.getKey().equalsIgnoreCase("localDictionaryThreshold")) {
this.localDictionaryThreshold(Integer.parseInt(entry.getValue()));
} else if (entry.getKey().equalsIgnoreCase("enableLocalDictionary"))
{
this.enableLocalDictionary((entry.getValue().equalsIgnoreCase("true")));
- } else {
+ } else if (entry.getKey().equalsIgnoreCase("sortcolumns")) {
--- End diff --
yes. changed it to same as table properties syntax
---
