Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2687#discussion_r216122724
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
    @@ -218,9 +240,10 @@ private Object avroFieldToObject(Schema.Field 
avroField, Object fieldValue) {
        *
        * @param type
        * @param fieldValue
    +   * @param unionField
        * @return
        */
    -  private boolean checkFieldValueType(Schema.Type type, Object fieldValue) 
{
    +  private boolean checkFieldValueType(Schema.Type type, Object fieldValue, 
Schema unionField) {
    --- End diff --
    
    Rename method to validateUnionFieldValue()


---

Reply via email to