Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r216207294
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -93,26 +101,19 @@ public static long
getTableStatusLastModifiedTime(AbsoluteTableIdentifier identi
}
}
- /**
- * get valid segment for given table
- *
- * @return
- * @throws IOException
- */
public ValidAndInvalidSegmentsInfo getValidAndInvalidSegments() throws
IOException {
- return getValidAndInvalidSegments(null, null);
- }
-
- public ValidAndInvalidSegmentsInfo getValidAndInvalidSegments(
- LoadMetadataDetails[] loadMetadataDetails) throws IOException {
- return getValidAndInvalidSegments(loadMetadataDetails, null);
+ if (configuration == null) {
+ configuration = FileFactory.getConfiguration();
+ }
+ return getValidAndInvalidSegments(null, null, configuration);
}
/**
* get valid segment for given load status details.
*/
public ValidAndInvalidSegmentsInfo getValidAndInvalidSegments(
- LoadMetadataDetails[] loadMetadataDetails, ReadCommittedScope
readCommittedScope)
+ LoadMetadataDetails[] loadMetadataDetails, ReadCommittedScope
readCommittedScope,
+ Configuration configuration)
--- End diff --
No need to pass as it is already available in the class
---
