Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2705#discussion_r216634097
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/TableSpec.java ---
    @@ -36,6 +37,14 @@
       private DimensionSpec[] dimensionSpec;
       private MeasureSpec[] measureSpec;
     
    +  // Many places we might have to access no-dictionary column spec.
    +  // but no-dictionary column spec are not always in below order like,
    +  // dictionary + no dictionary + complex + measure
    +  // when sort_columns are empty, no columns are selected for sorting.
    +  // so, spec will not be in above order.
    +  // Hence NoDictionaryDimensionSpec will be useful and it will be subset 
of dimensionSpec.
    +  private List<DimensionSpec> NoDictionaryDimensionSpec;
    --- End diff --
    
    done.


---

Reply via email to