Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2683#discussion_r217589323
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/TestUtil.java ---
    @@ -36,38 +36,34 @@
     import org.apache.avro.generic.GenericDatumReader;
     import org.apache.avro.generic.GenericDatumWriter;
     import org.apache.avro.io.DecoderFactory;
    -import org.apache.avro.io.Encoder;
     import org.apache.avro.io.JsonDecoder;
     import org.apache.hadoop.conf.Configuration;
    -import org.junit.Assert;
     
    [email protected]("Test")
     public class TestUtil {
     
    -  public static Configuration configuration = new Configuration();
    +  public static final Configuration configuration = new Configuration();
    --- End diff --
    
    Because now CLI is a separate module and testcase in CLI need to use 
TestUtil to write carbonfiles using SDK, so I have to move the TestUtil to src 
so that CLI testcase can use it. Is there other way?


---

Reply via email to