Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2724#discussion_r217900042
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
    @@ -470,11 +526,29 @@ public CarbonWriter 
buildThreadSafeWriterForAvroInput(org.apache.avro.Schema avr
         return new AvroCarbonWriter(loadModel, configuration);
       }
     
    +  /**
    +   * Build a {@link CarbonWriter}, which accepts Avro object
    +   *
    +   * @param avroSchema   avro Schema object {org.apache.avro.Schema}
    +   * @param numOfThreads number of threads() in which .write will be 
called.
    +   * @return AvroCarbonWriter
    +   * @throws IOException
    --- End diff --
    
    since you are modifying this, please complete all comment


---

Reply via email to