Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2732#discussion_r218635891
  
    --- Diff: core/src/main/java/net/jpountz/lz4/LZ4CompressorWithLength.java 
---
    @@ -0,0 +1,225 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +// code ported from https://github.com/lz4/lz4-java/issues/119
    +// remove this class when new version > 1.4.1 released
    +// this is only for test
    +
    +/*
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package net.jpountz.lz4;
    +
    +import java.nio.ByteBuffer;
    +import java.util.Arrays;
    +
    +/**
    + * Covenience class to include the length of the original decompressed data
    + * in the output compressed data, so that the user does not need to save
    + * the length at anywhere else.  The compressed data must be decompressed 
by
    + * {@link LZ4DecompressorWithLength} and is NOT compatible with any other
    + * decompressors in lz4-java or any other lz4 tools.  This class 
deliberately
    + * does not extend {@link LZ4Compressor} because they are not 
interchangable.
    + */
    +
    +public class LZ4CompressorWithLength {
    --- End diff --
    
    yes.  These codes didn't not packed in a released jar. Here we cope it only 
for test.  See comment in L18-20


---

Reply via email to