[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support

[kunal642]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2726#discussion_r218715543
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoderMeta.java
 ---
    @@ -132,6 +132,10 @@ private void writeMinMax(DataOutput out) throws 
IOException {
           out.writeDouble((Double) getMaxValue());
           out.writeDouble((Double) getMinValue());
           out.writeDouble(0d); // unique value is obsoleted, maintain for 
compatibility
    +    } else if (dataType == DataTypes.FLOAT) {
    +      out.writeDouble((Float) getMaxValue());
    --- End diff --
    
    used writeFloat instead of writeDouble


---