GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/2734
[CARBONDATA-2946] Bloom filter backward compatibility with adaptive
encoding and Refactor
**(1)** Refactored the already existing code in ColumnPageWrapper to fill
the data to vector
**(2)** **Problem:**
Bloom filter writing is like measure column. So backward compatibility is
not ensured. If we are writing it as like measure column, filter queries will
fail.
**Solution:**
Write the bloom also same as that of no dictionary column. Take care of
null bitsets(i.e null values) as null would have been written as 0 as the page
is written like that of measure.
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhatchayani/carbondata CARBONDATA-2946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2734
----
commit 984eef1879d92514000a8f5e05bf82e935403066
Author: dhatchayani <dhatcha.official@...>
Date: 2018-09-19T12:37:11Z
[CARBONDATA-2946] Bloom filter backward compatibility with adaptive
encoding and Refactor
----
---
