Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2732#discussion_r219024705
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/compression/Lz4Compressor.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.compression;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.DoubleBuffer;
+import java.nio.FloatBuffer;
+import java.nio.IntBuffer;
+import java.nio.LongBuffer;
+import java.nio.ShortBuffer;
+import java.util.Arrays;
+
+import org.apache.carbondata.core.util.ByteUtil;
+
+import net.jpountz.lz4.LZ4Compressor;
+import net.jpountz.lz4.LZ4Factory;
+import net.jpountz.lz4.LZ4FastDecompressor;
+
+
+public class Lz4Compressor implements Compressor {
+
+ private LZ4Compressor compressor;
+ private LZ4FastDecompressor decompressor;
+
+ public Lz4Compressor() {
+ LZ4Factory factory = LZ4Factory.fastestInstance();
+ compressor = factory.fastCompressor();
+ decompressor = factory.fastDecompressor();
+ }
+
+ @Override
+ public String getName() {
+ return "lz4";
+ }
+
+ @Override
+ public byte[] compressByte(byte[] unCompInput) {
+ // get max compressed length
--- End diff --
If this code is copied from LZ4, better to make a declaration
---
