Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2665#discussion_r219067294
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
---
@@ -364,6 +365,13 @@ public DataMapMeta getMeta() {
return null;
}
+ @Override
+ public boolean isSupport(Expression expression) {
+ // this method is used for choosing cg/fg datamap
+ // for default datamap always return false
+ return false;
--- End diff --
I think you can by default return true here, even it has no side effect,
but it will make sense for code reading: default datamap can handle all the
expressions
---
