Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2739#discussion_r219531131
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2226,7 +2226,11 @@ public static String
getFilePathExternalFilePath(String path, Configuration conf
if
(dataFile.getName().endsWith(CarbonCommonConstants.FACT_FILE_EXT)) {
return dataFile.getAbsolutePath();
} else if (dataFile.isDirectory()) {
- return getFilePathExternalFilePath(dataFile.getAbsolutePath(),
configuration);
+ if (getFilePathExternalFilePath(dataFile.getAbsolutePath(),
configuration) == null) {
--- End diff --
Please add/modify existing test case to handle this scenario
Also please test query with an empty folder. we have other places in the
code where we recursively read.
Review and handle if a problem exists in that flow.
example:
CarbonTable.getFirstIndexFile --> also has same issue
---
