Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2736#discussion_r219704518
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/RowConverterImpl.java
---
@@ -69,11 +69,14 @@
private Map<Object, Integer>[] localCaches;
+ private boolean isStreamingFlow;
+
public RowConverterImpl(DataField[] fields, CarbonDataLoadConfiguration
configuration,
- BadRecordsLogger badRecordLogger) {
+ BadRecordsLogger badRecordLogger, boolean isStreamingFlow) {
--- End diff --
Better not mention about streaming in core layer. Change boolean to
`isConvertToBinary` and add javadoc about what does it do
---
