GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2751

    WIP:[CARBONDATA-2946] Add bloomindex version info file for compatibility

    we add an empty version file to indicate the version of the bloomindex.
    The original reason is that in 1.5.0, for non-dictionary primitive fields,
    carbondata changes the encoding for them -- using primitives instead of 
literal bytes.
    For compatibility for the previous version of bloom index,
    we add an version info file to indicate the version of this index file.
    
    During writing the bloom index, we always write the bloom value the same as 
that in carbon file,
    while during querying, we will convert the filter value based on the 
version.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0924_bloom_compatibility

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2751
    
----
commit ed8bf431873cbf41928255246fb311c435b32aee
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-09-24T03:18:36Z

    Add bloomindex version info file for compatibility
    
    we add an empty version file to indicate the version of the bloomindex.
    The original reason is that in 1.5.0, for non-dictionary primitive fields,
    carbondata changes the encoding for them -- using primitives instead of 
literal bytes.
    For compatibility for the previous version of bloom index,
    we add an version info file to indicate the version of this index file.
    
    During writing the bloom index, we always write the bloom value the same as 
that in carbon file,
    while during querying, we will convert the filter value based on the 
version.

----


---

Reply via email to