Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2748#discussion_r219748229
  
    --- Diff: 
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala
 ---
    @@ -269,4 +273,94 @@ object CarbonSparkDataSourceUtil {
         }
         model
       }
    +
    +  def validateTableOptions(options: Map[String, String], schema: Schema): 
Unit = {
    --- End diff --
    
    I don't expect any validations here. We cannot validate all the properties 
during load. We can do validation only for the properties which it supports. 
And also those validations should be inside sdk interfaces not here.


---

Reply via email to