Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2759#discussion_r220500265
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -182,10 +224,15 @@ public long getUsableMemory() {
*/
public static MemoryBlock allocateMemoryWithRetry(long taskId, long size)
throws MemoryException {
+ return allocateMemoryWithRetry(taskId, size, false);
+ }
+
+ public static MemoryBlock allocateMemoryWithRetry(long taskId, long
size, boolean isDriver)
--- End diff --
Better add overloaded method to take enum for offheap or onheap memory
required.
---
