Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2770#discussion_r220885228
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
    @@ -1954,7 +1954,16 @@ public static void 
removeNullValues(DimensionColumnPage dimensionColumnPage, Bit
                 bitSet.flip(i);
               }
             }
    -      } else {
    +      } else if (null != dimensionColumnPage.getNullBits() && 
!dimensionColumnPage.getNullBits()
    +          .isEmpty() && dimensionColumnPage.isExplicitSorted() && 
!dimensionColumnPage
    --- End diff --
    
    it should be `dimensionColumnPage.isAdaptiveEncoded()` remove `!`


---

Reply via email to