Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2738#discussion_r221149564
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
    @@ -90,6 +91,33 @@ public T readNextRow() throws IOException, 
InterruptedException {
         return currentReader.getCurrentValue();
       }
     
    +  /**
    +   * Read and return next string row object
    +   */
    +  public Object[] readNextStringRow() throws IOException, 
InterruptedException {
    --- End diff --
    
    readNextStringRow is not a standard API I think. It can not work with 
nested complex data types. Like Array[Array[...]], Struct[Array]. 
    
    I suggest to add a better API like CarbonRow wrapping on object[] and give 
reader utility methods like getInt, getString in CarbonRow .
    
    If it can't be finished in this PR scope, temporarily you can move this 
string making logic to JNI layer code so that it can be improved later. 
**Adding in java SDK layer will add more confusion to users**


---

Reply via email to