GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2786
[CARBONDATA-2967] Fixed NPE for preaggregate queries
**Problem:**
Preaggregate select queries require table path of parent table to access
dictionary files. Therefore in executor CarbonMetadata class was used to get
parent table object. As CarbonMetadata class is only meant to be used in
driver and is not filled with carbontable objects for select queries therefore
the query was throwing NPE.
**Solution:**
Pass parent table path from driver to executor by adding a new variable in
RelationIdentifier. This will not be written to thrift, instead will be used to
carry tablePath property from driver to executor.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata preagg_query_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2786
----
commit ac358ad2f6b6e1d0451a28fae2ecdca23f30a409
Author: kunal642 <kunalkapoor642@...>
Date: 2018-09-28T12:11:32Z
Fixed NPE for preaggregate queries
----
---
