Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2790#discussion_r221411334
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -115,11 +115,13 @@ public CarbonReaderBuilder
withHadoopConf(Configuration conf) {
hadoopConf = FileFactory.getConfiguration();
}
CarbonTable table;
- if (filterExpression != null) {
- table = CarbonTable.buildTable(tablePath, tableName, hadoopConf);
- } else {
- table = CarbonTable.buildDummyTable(tablePath);
- }
+ // now always infer schema. TODO:Refactor in next version.
+ table = CarbonTable.buildTable(tablePath, tableName, hadoopConf);
+ // if (filterExpression != null) {
--- End diff --
If it is useless, just remove them. We are using git, no need to comment
the useless code
---
