Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2779#discussion_r221414692
  
    --- Diff: 
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
 ---
    @@ -0,0 +1,55 @@
    +/*
    --- End diff --
    
    My comment : only for 4 parameters , copy the whole 
file(CarbonDataSourceScan.scala) for spark 2.3 integration,  may not require. 
see if can add the judgement for different spark version with different 
code/parameters.


---

Reply via email to