GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/2794
[CARBONDATA-2985]Fix issues in Table level compaction and TableProperâ¦
Issue :-
1. If 2nd Level compaction is 1 like 2,1 or 6,1 then only 1st time
compaction is done subsequent compaction are ignored . ( like if 2,1 is given
then only 0.1 is segment is created and other segments are ignore forever )
2. Table level compaction does not support ,0 as 2nd level compaction
value but system level compaction supports same.
Solution :-
1. if 2nd level compaction value is 1 then user does not want 2nd level
compaction at all which mean 2nd level compaction can be set to 0.
2. remove check to support 2nd level compaction as 0 in table level.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NA
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
Added
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
FT is added
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata compaction_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2794.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2794
----
commit 9b52f22d5c9577143f03ab1691abc9b72675e212
Author: BJangir <babulaljangir111@...>
Date: 2018-10-01T18:47:29Z
[CARBONDATA-2985]Fix issues in Table level compaction and TableProperties
----
---
