Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2729#discussion_r224987867
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/AbstractRawColumnChunk.java
 ---
    @@ -129,4 +138,35 @@ public void setDataChunkV3(DataChunk3 dataChunkV3) {
       public void setMinMaxFlagArray(boolean[] minMaxFlagArray) {
         this.minMaxFlagArray = minMaxFlagArray;
       }
    +  public boolean isAdaptiveForDictionary() {
    --- End diff --
    
    please add comments for public methods for better maintainability


---

Reply via email to