GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2817
[CARBONDATA-3009] Move method for mergeIndex to correct the place
Currently the entry point of function for mergeIndex is in `CommonUtil`
which is not proper. Here in this commit, we will move this to the right
place.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`only internal interface has been changed`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`Not required. We just moved the method from one place to another`
- How it is tested? Please attach test report.
`Tested in local`
- Is it a performance related change? Please attach the performance
test report.
`NO`
- Any additional information to help reviewers in testing this
change.
`We should provide the interfaces and functions in proper place and avoid
god-class`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata
181016_opt_merge_index_method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2817
----
commit 1d1f6ad61d1a44f5cf78dac659f90347fe4f1a0c
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-10-16T06:57:16Z
Move method for mergeIndex to correct the place
Currently the entry point of function for mergeIndex is in `CommonUtil`
which is not proper. Here in this commit, we will move this to the right
place.
----
---
