GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2819

    [CARBONDATA-3012] Added support for full scan queries for vector direct 
fill.

    After decompressing the page in our V3 reader we can immediately fill the 
data to a vector without any condition checks inside loops. So here complete 
column page data is set to column vector in a single batch and gives back data 
to Spark/Presto.
    For this purpose, a new method is added in `ColumnPageDecoder`
    ```
    ColumnPage decodeAndFillVector(byte[] input, int offset, int length, 
ColumnVectorInfo vectorInfo,
          BitSet nullBits, boolean isLVEncoded)
    ```
    The above method takes vector fill it in a single loop without any checks 
inside loop.
    
    And also added new method inside `DimensionDataChunkStore`
    
    ```
     void fillVector(int[] invertedIndex, int[] invertedIndexReverse, byte[] 
data,
          ColumnVectorInfo vectorInfo);
    ```
    The above method takes vector fill it in a single loop without any checks 
inside loop.
    
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata perf-full-scan

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2819
    
----
commit 358299f90df98272723f22f43ab025bd1e7fa3e8
Author: ravipesala <ravi.pesala@...>
Date:   2018-10-16T05:02:18Z

    Add carbon property to configure vector based row pruning push down

commit 658d8cb02b657e9b5887c0348971b9d92087fab2
Author: ravipesala <ravi.pesala@...>
Date:   2018-10-16T06:00:43Z

    Added support for full scan queries for vector direct fill.

----


---

Reply via email to